Remove the temporary step-down/prepare feature flag once WT-18422 lands

ExportXMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Configuration, Cursors, Transactions
    • None
    • Storage Engines - Transactions
    • 58.435
    • None
    • 3

      Background

      WT-18722 adds a temporary, diagnostic-only feature flag that bypasses two blanket asserts so prepared transactions can proceed while the step-down timestamp is set:

      • __wt_txn_prepare (src/txn/txn.c)
      • __session_commit_transaction (src/session/session_api.c)

      That flag exists only to make WT-18717's layered-iteration prepare-block fix testable and mergeable against develop ahead of WT-18422. WT-18422 removes both underlying asserts permanently as part of its own work (replacing the blanket ban with the real straddler check), which makes the flag redundant.

      Ask

      Once WT-18422 merges to develop:

      1. Delete the temporary flag added in WT-18722, along with the if bypass wrapped around each of the two asserts.
      2. Confirm neither assert (nor its replacement logic) still references the flag anywhere.
      3. Confirm the WT-18717 Python regression test (test_layered_async_stepdown16.py or its equivalent) still passes without the flag once WT-18422's real straddler-aware checks are in place.

      Relates to

      • WT-18722 (introduces the flag this removes)
      • WT-18717 (the fix the flag was added to test)
      • WT-18422 (the change that makes the flag redundant)

            Assignee:
            [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            Chenhao Qu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: