Summary

During the meeting, we agreed to implement a code-ownership-based review process for the Foundations team components.

We will use Option 2: CODEOWNERS for the entire Foundations team GitHub alias, without round-robin assignment with small additions.

Requirements

• The Foundations team review must not be mandatory.
  • If needed, reviewers can remove the Foundations team from the reviewers list and merge the PR after receiving one LGTM from a reviewer outside the team.
• Every PR that modifies a Foundations-owned component should generate a notification in the KTLO Foundations Slack channel.
• The triager is responsible for finding a reviewer for each such notification.
  • Team members can also volunteer to review PRs.
• We already have a GitHub team for the Foundations team, so it should be reused.
• PRs created by Foundations team members should be excluded from these notifications.

Implementation Steps

1. Identify the Foundations-owned components and corresponding source files.
2. Implement the GitHub CODEOWNERS configuration.
3. Add the mechanism for sending Slack notifications to the KTLO Foundations channel.
4. Update the triager responsibilities to include finding reviewers for these PRs.
5. Communicate the new review process to the other teams.

Follow-up

As a follow-up, we should create a Foundations knowledge matrix wiki page and share it with the other teams. The goal is to make it clear who has more experience in each area and help reviewers find the right person for a particular change.

There is[ an existing document|https://wiki.corp.mongodb.com/pages/viewpage.action?pageId=96675672&spaceKey=WT&title=Aspect%2BCoverage] that we can potentially reuse as a starting point.