Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2020

Improve messages for checksum error

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0
    • Labels:
      None

      Description

      Serviceability would be improved if the messages produced in case of checksum error were a little more verbose.

      Instead of

      2015-07-23T19:35:13.956+0200 E STORAGE  [conn725] WiredTiger (0) [1437672913:956359][64247:0x7ff6ff6aa700], file:factee_geographic/collection/19-4376327810822422286.wt, cursor.next: read checksum error [4096B @ 4692008960, 3560417636 != 0]
      

      Suggest for example (for the case where header checksum doesn't match pageref checksum):

      checkum error in file ...: checksum in header of block of length ... at offset ... is ..., expected ...
      

      or (for the case where computed checksum doesn't match checksum header):

      checkum error in file ...: checksum in header of block of length ... at offset ... is ... as expected, but checksum computed from content of block is ...
      

        Issue Links

          Activity

          Hide
          bruce.lucas Bruce Lucas added a comment -

          Thanks Keith, lgtm.

          Show
          bruce.lucas Bruce Lucas added a comment - Thanks Keith, lgtm.
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'}

          Message: WT-2020: clarify checksum error failure messages.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/24fc979055bf6a0863eb0a70639c55b348296a5f

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2020 : clarify checksum error failure messages. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/24fc979055bf6a0863eb0a70639c55b348296a5f
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'}

          Message: Merge pull request #2086 from wiredtiger/wt-2020-checksum-error-messages

          WT-2020: clarify checksum error failure messages.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/7d6075c5ad327d14a0b59410b84a2e5678069e4d

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'} Message: Merge pull request #2086 from wiredtiger/wt-2020-checksum-error-messages WT-2020 : clarify checksum error failure messages. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/7d6075c5ad327d14a0b59410b84a2e5678069e4d
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'}

          Message: Merge pull request #2086 from wiredtiger/wt-2020-checksum-error-messages

          WT-2020: clarify checksum error failure messages.
          (cherry picked from commit 7d6075c5ad327d14a0b59410b84a2e5678069e4d)
          Branch: mongodb-3.0
          https://github.com/wiredtiger/wiredtiger/commit/00f7e9a47fa0774f87e88dabbbf09a01b99d80ef

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'} Message: Merge pull request #2086 from wiredtiger/wt-2020-checksum-error-messages WT-2020 : clarify checksum error failure messages. (cherry picked from commit 7d6075c5ad327d14a0b59410b84a2e5678069e4d) Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/00f7e9a47fa0774f87e88dabbbf09a01b99d80ef

            People

            • Assignee:
              keith.bostic Keith Bostic
              Reporter:
              bruce.lucas Bruce Lucas
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: