Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2039

Don't allow log records larger than 4GB

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0
    • Labels:
      None
    • # Replies:
      9
    • Last comment by Customer:
      true

      Description

      We have a lot of places where we expect the record length and offset to be 4 bytes. We see assertion failures on a lsn comparison failing due to updates to the LSN. Need to document that record/offset limitation.

        Issue Links

          Activity

          Hide
          michael.cahill Michael Cahill added a comment -

          Sue LoVerso, did we agree on a change here? It would be worth writing a test that tries to create a log record larger than 4GB in one transaction to at least make sure it fails gracefully at the moment...

          Show
          michael.cahill Michael Cahill added a comment - Sue LoVerso , did we agree on a change here? It would be worth writing a test that tries to create a log record larger than 4GB in one transaction to at least make sure it fails gracefully at the moment...
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-2039 Add error check and unit test for log records over 4Gb.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/8e5206e83eb0646042078d08a027cd9be240a1f6

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-2039 Add error check and unit test for log records over 4Gb. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/8e5206e83eb0646042078d08a027cd9be240a1f6
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-2039 Remove alternate errno comment.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/0f3e03df17e8b976bcfa65bb0243ef3ec33a6dcf

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-2039 Remove alternate errno comment. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/0f3e03df17e8b976bcfa65bb0243ef3ec33a6dcf
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-2039 Whitespace
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/40a36e82cbee373022aea15cb095e92b7f4abd00

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-2039 Whitespace Branch: develop https://github.com/wiredtiger/wiredtiger/commit/40a36e82cbee373022aea15cb095e92b7f4abd00
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-2039 Update format per review. Update error message to be consistent
          with other similar messages.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/fc5ba69eaf35904bf413bcda715beba0298b117e

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-2039 Update format per review. Update error message to be consistent with other similar messages. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/fc5ba69eaf35904bf413bcda715beba0298b117e
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'}

          Message: Merge pull request #2207 from wiredtiger/large-records

          WT-2039 Add error check and unit test for log records over 4Gb.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/75a46556bbca11630c045d46a51282a7defad209

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'} Message: Merge pull request #2207 from wiredtiger/large-records WT-2039 Add error check and unit test for log records over 4Gb. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/75a46556bbca11630c045d46a51282a7defad209
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'}

          Message: WT-2039 Add error check and unit test for log records over 4Gb.

          Merge pull request #2207 from wiredtiger/large-records

          (cherry picked from commit 75a46556bbca11630c045d46a51282a7defad209)
          Branch: mongodb-3.0
          https://github.com/wiredtiger/wiredtiger/commit/cd8ae463f0830e56ec66de73de78ca81041615b2

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'} Message: WT-2039 Add error check and unit test for log records over 4Gb. Merge pull request #2207 from wiredtiger/large-records (cherry picked from commit 75a46556bbca11630c045d46a51282a7defad209) Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/cd8ae463f0830e56ec66de73de78ca81041615b2
          Hide
          sue.loverso Sue LoVerso added a comment -

          Although we check the size of a log record, I still need to make offsets be 32 bits.

          Show
          sue.loverso Sue LoVerso added a comment - Although we check the size of a log record, I still need to make offsets be 32 bits.
          Hide
          michael.cahill Michael Cahill added a comment -

          Opened WT-2215 for the remaining work so this ticket can be closed.

          Show
          michael.cahill Michael Cahill added a comment - Opened WT-2215 for the remaining work so this ticket can be closed.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since reply:
                1 year, 18 weeks, 6 days ago
                Date of 1st Reply: