Michael Cahill added a comment - Sep 08 2015 05:23:51 AM +00:00 During review, I found two bugs by inspection: In block_addr.c : 86 /* 87 * __wt_block_addr_valid -- 88 * Return if an address cookie is valid. 89 */ 90 int 91 __wt_block_addr_valid(WT_SESSION_IMPL *session, 92 WT_BLOCK *block, const uint8_t *addr, size_t addr_size, int live) 93 { 94 wt_off_t offset; 95 uint32_t cksum, size; ... 100 101 /* Crack the cookie. */ 102 WT_RET(__wt_block_buffer_to_addr(block, addr, &offset, &size, &cksum)); ... 112 113 /* Check if it's past the end of the file. */ 114 return (offset + size > block->fh->size ? 0 : 1); 115 } Here an error from __wt_block_buffer_to_addr will be treated as a valid address. In rec_track.c : 448 int 449 __wt_ovfl_reuse_search(WT_SESSION_IMPL *session, WT_PAGE *page, 450 uint8_t **addrp, size_t *addr_sizep, 451 const void *value, size_t value_size) 452 { ... 467 if ((reuse = __ovfl_reuse_skip_search(head, value, value_size)) == NULL) 468 return (0); 469 ... 474 if (WT_VERBOSE_ISSET(session, WT_VERB_OVERFLOW)) 475 WT_RET(__ovfl_reuse_verbose(session, page, reuse, "reclaim")); 476 return (1); Here an error from __ovfl_reuse_verbose will be treated as found (which it is) but the error return is lost.

Githook User added a comment - Sep 11 2015 02:08:14 AM +00:00 Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: WT-2093 Use the C99 bool type to clarify when functions return true/false. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/5a440d45fc052e5ebde92e0266d0dae93f2c701d

Githook User added a comment - Sep 11 2015 02:08:16 AM +00:00 Author: {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexg@wiredtiger.com'} Message: WT-2093 Make types match. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/39d8cef6c1a693327e3ea8a2c7732ddfdb3fbfaf

Githook User added a comment - Sep 11 2015 02:08:17 AM +00:00 Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2178 from wiredtiger/use-bool WT-2093 Use the C99 bool type to clarify when functions return true/false Branch: develop https://github.com/wiredtiger/wiredtiger/commit/d9391c0df4dc38c8ea571bde4808ced194d7cff0

Githook User added a comment - Sep 16 2015 08:27:02 AM +00:00 Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2093 : __wt_block_addr_valid() didn't distinguish between a valid address and an underlying error cracking the address cookie. Change the name to __wt_block_addr_invalid and then return 0 for "is-valid" and an error code for any invalid blocks. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/52eceffbc938e577a21954c03a986f66670f1ac3

Githook User added a comment - Sep 16 2015 08:27:03 AM +00:00 Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2093 : __wt_ovfl_reuse_search() returned 0/1 for "overflow record found/not-found", which could discard real error values from underlying functions it called. Instead of returning found/not-found, return a standard 0/error value, and use the stored address of any found overflow record as the found/not-found status. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/f0ff426b5c2c15c6dde3259271745e2f2d786784

Githook User added a comment - Sep 16 2015 08:27:06 AM +00:00 Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2185 from wiredtiger/wt-2093-cleanup WT-2093 Fix bugs treating error returns as booleans Branch: develop https://github.com/wiredtiger/wiredtiger/commit/8a8867b859d9b1bdeb00084495bd925828ae51e0

Githook User added a comment - Sep 30 2015 02:23:57 AM +00:00 Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: WT-2093 Use the C99 bool type to clarify when functions return true/false Merge pull request #2178 from wiredtiger/use-bool (cherry picked from commit d9391c0df4dc38c8ea571bde4808ced194d7cff0) Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/8e212cf8907a5d2462dead47aebcce074dd3c066