Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2093

Use the C "bool" type for true/false function returns

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • WT2.7.0
    • None
    • None

    Description

      In a recent code review, there was some discussion about when function returns should be compared against an explicit zero vs if (!func()). The answer is if the function is returning a boolean, but WT has mapped that to the int type for portability.

      However, C has had a bool type since C99 via <stdbool.h>, also supported by Visual Studio 2013 and above.

      Investigate converting WT to use explicit bool types to make it clear when expressions need to be compared against zero.

      Attachments

        Issue Links

          is depended on by

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-20060 WiredTiger changes for MongoDB 3.1.8

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-20408 WiredTiger changes for MongoDB 3.1.9

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-20479 WiredTiger changes for MongoDB 3.0.7

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              michael.cahill@mongodb.com Michael Cahill
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: