Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2155

Remove F_CAS_ATOMIC

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major - P3
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: WT2.7.0
        • Labels:
          None
        • # Replies:
          3
        • Last comment by Customer:
          true

          Description

          There is only one place left in the code that uses the F_CAS_ATOMIC macro - in the cache pool implementation.

          That code only needs a single flag in the fields structure to be atomic, so the compare and swap might as well happen on a specific field, rather than a flags variable.

            Issue Links

            is depended on by

            Improvement - An improvement or enhancement to an existing feature or task. SERVER-20771 WiredTiger changes for MongoDB 3.2.0-rc0

            • Major - P3 - Major loss of function.
            • Closed

              Activity

              • Comments
              Ascending order - Click to sort in descending order
              Hide
              Permalink
              michael.cahill Michael Cahill added a comment -

              I've made this a little broader – I think we can get rid of all uses of flags_atomic and all related macros...

              Show
              michael.cahill Michael Cahill added a comment - I've made this a little broader – I think we can get rid of all uses of flags_atomic and all related macros...
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexg@wiredtiger.com'}

              Message: WT-2155 Remove last use of F_CAS_ATOMIC and the associated macro.
              Branch: develop
              https://github.com/wiredtiger/wiredtiger/commit/996fe0cc5924708e1476228bfbb28a04ba3115ae

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexg@wiredtiger.com'} Message: WT-2155 Remove last use of F_CAS_ATOMIC and the associated macro. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/996fe0cc5924708e1476228bfbb28a04ba3115ae
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

              Message: Merge pull request #2239 from wiredtiger/remove-flag-cas-atomic

              WT-2155 Remove last use of F_CAS_ATOMIC and the associated macro.
              Branch: develop
              https://github.com/wiredtiger/wiredtiger/commit/0d74bc686a3a616bfa40e3272a0a04e6958c3892

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2239 from wiredtiger/remove-flag-cas-atomic WT-2155 Remove last use of F_CAS_ATOMIC and the associated macro. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/0d74bc686a3a616bfa40e3272a0a04e6958c3892

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Days since reply:
                    1 year, 38 weeks ago
                    Date of 1st Reply: