Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2189

Fix F_SET / F_ISSET confusion

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0
    • Component/s: None
    • Labels:
      None

      Description

      In WiredTiger we have macros for dealing with bitwise flags called F_SET (to set a flag) and F_ISSET (to check whether a flag is set). It is easy to confuse these two, and accidentally set a flag when intending to check for it.

      Make F_SET (and F_CLR while we're in the neighborhood) into void expressions to avoid this class of bug.

        Attachments

          Activity

            People

            • Assignee:
              michael.cahill Michael Cahill
              Reporter:
              michael.cahill Michael Cahill
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: