Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2216

simplify row-store search loop slightly

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.8.0
    • Labels:
      None

      Description

      There's a test for internal pages with a single child in the row-store search function:

      /*
       * Fast-path internal pages with one child, a common case for
       * the root page in new trees.
       */
      if (pindex->entries == 1) {
              descent = pindex->index[0];
              goto descend;
      }
      

      Michael Cahill, you put this code in https://github.com/wiredtiger/wiredtiger/commit/875c10c72b6f5bdb53a8e14fc7e15f7491d6b412, do you remember where this made a difference?

      It seems to me it's only useful until we split the root, and then it's wasted from that point on, was there a benchmark that triggered this?

        Attachments

        1. aws.clang36
          9 kB
        2. aws.gcc48
          9 kB
        3. pixie.clang33
          9 kB
        4. rr
          1 kB

          Activity

            People

            • Assignee:
              keith.bostic Keith Bostic
              Reporter:
              keith.bostic Keith Bostic
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: