Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0
    • Labels:
      None
    • # Replies:
      10
    • Last comment by Customer:
      true

      Description

      WiredTiger treats time_t as an integral type, and it's only guaranteed to be an arithmetic type, plus there's no guarantee the value is represented in any particular way, so arithmetic operations aren't necessarily safe.

      I can't imagine it's a real bug, but it's also an easy change to be safe.

        Issue Links

          Activity

          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-2220 Create WT_TIMEDIFF_US and fix use of constants.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/be02ec56d53e4bf260a40af64cb75ea69d4ee1f6

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-2220 Create WT_TIMEDIFF_US and fix use of constants. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/be02ec56d53e4bf260a40af64cb75ea69d4ee1f6
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'}

          Message: WT-2220: WT_TIMEDIFF_US doesn't appear in core WiredTiger, don't
          complain it's not used (it is used in wtperf).
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/f5fe63156d35c2430221bc13531ece36f697b857

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2220 : WT_TIMEDIFF_US doesn't appear in core WiredTiger, don't complain it's not used (it is used in wtperf). Branch: develop https://github.com/wiredtiger/wiredtiger/commit/f5fe63156d35c2430221bc13531ece36f697b857
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexander.gorrod@mongodb.com'}

          Message: Merge pull request #2308 from wiredtiger/wt-2220-wt_timediff

          WT-2220 Split WT_TIMEDIFF macro into unit specific macros.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/e2f11301fe0f877225dbd102aba458b887cd40ee

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexander.gorrod@mongodb.com'} Message: Merge pull request #2308 from wiredtiger/wt-2220-wt_timediff WT-2220 Split WT_TIMEDIFF macro into unit specific macros. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/e2f11301fe0f877225dbd102aba458b887cd40ee
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'name': u'Ramon Fernandez', u'email': u'rfmnyc@gmail.com'}

          Message: Import wiredtiger-wiredtiger-mongodb-3.2.0-rc3-177-g9d375e3.tar.gz from wiredtiger branch mongodb-3.2

          ref: d9ec1ff..9d375e3

          16c0a1a WT-1315 Fix some leaks with join cursors.
          59857f9 WT-2222 Add statistics for named snapshots.
          4368d39 WT-1315 Cursor join implementation
          a72ddb7 WT-2218 Add truncate stats
          fb9cebe WT-2224 Track which deleted refs are discarded by a split.
          e2f1130 WT-2220 Split WT_TIMEDIFF macro into unit specific macros.
          be412b5 WT-2182 when internal pages grow large enough, split them into their parents
          ce8c091 WT-2219 Enhancements to in-memory testing
          347d922 WT-2220 time_t cleanup.
          08c0fcd WT-2217 change WT_CURSOR.insert to clear "set" key/value on return
          d1b5e7f WT-2135 Fix log_only setting for backup cursor. Fix initialization.
          78bd4ac WT-2210 raw compression fails if row-store recovery precedes column-store recovery
          c1b2634 WT-2182 fixes for splitting up the tree.
          0a1ee34 WT-2199 Fix transaction sync inconsistency.
          ee31bb2 WT-2182 Simplify the split deepen logic.
          c360d53 WT-2212 Add a "use_environment" config to "wiredtiger_open"
          3f132a4 WT-2182 detect internal page split races.
          Branch: master
          https://github.com/mongodb/mongo/commit/a0771ea5ec1b44537d3c409e3d712db24fd8e6bb

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'name': u'Ramon Fernandez', u'email': u'rfmnyc@gmail.com'} Message: Import wiredtiger-wiredtiger-mongodb-3.2.0-rc3-177-g9d375e3.tar.gz from wiredtiger branch mongodb-3.2 ref: d9ec1ff..9d375e3 16c0a1a WT-1315 Fix some leaks with join cursors. 59857f9 WT-2222 Add statistics for named snapshots. 4368d39 WT-1315 Cursor join implementation a72ddb7 WT-2218 Add truncate stats fb9cebe WT-2224 Track which deleted refs are discarded by a split. e2f1130 WT-2220 Split WT_TIMEDIFF macro into unit specific macros. be412b5 WT-2182 when internal pages grow large enough, split them into their parents ce8c091 WT-2219 Enhancements to in-memory testing 347d922 WT-2220 time_t cleanup. 08c0fcd WT-2217 change WT_CURSOR.insert to clear "set" key/value on return d1b5e7f WT-2135 Fix log_only setting for backup cursor. Fix initialization. 78bd4ac WT-2210 raw compression fails if row-store recovery precedes column-store recovery c1b2634 WT-2182 fixes for splitting up the tree. 0a1ee34 WT-2199 Fix transaction sync inconsistency. ee31bb2 WT-2182 Simplify the split deepen logic. c360d53 WT-2212 Add a "use_environment" config to "wiredtiger_open" 3f132a4 WT-2182 detect internal page split races. Branch: master https://github.com/mongodb/mongo/commit/a0771ea5ec1b44537d3c409e3d712db24fd8e6bb
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'name': u'Ramon Fernandez', u'email': u'rfmnyc@gmail.com'}

          Message: Import wiredtiger-wiredtiger-mongodb-3.2.0-rc3-177-g9d375e3.tar.gz from wiredtiger branch mongodb-3.2

          ref: d9ec1ff..9d375e3

          16c0a1a WT-1315 Fix some leaks with join cursors.
          59857f9 WT-2222 Add statistics for named snapshots.
          4368d39 WT-1315 Cursor join implementation
          a72ddb7 WT-2218 Add truncate stats
          fb9cebe WT-2224 Track which deleted refs are discarded by a split.
          e2f1130 WT-2220 Split WT_TIMEDIFF macro into unit specific macros.
          be412b5 WT-2182 when internal pages grow large enough, split them into their parents
          ce8c091 WT-2219 Enhancements to in-memory testing
          347d922 WT-2220 time_t cleanup.
          08c0fcd WT-2217 change WT_CURSOR.insert to clear "set" key/value on return
          d1b5e7f WT-2135 Fix log_only setting for backup cursor. Fix initialization.
          78bd4ac WT-2210 raw compression fails if row-store recovery precedes column-store recovery
          c1b2634 WT-2182 fixes for splitting up the tree.
          0a1ee34 WT-2199 Fix transaction sync inconsistency.
          ee31bb2 WT-2182 Simplify the split deepen logic.
          c360d53 WT-2212 Add a "use_environment" config to "wiredtiger_open"
          3f132a4 WT-2182 detect internal page split races.
          Branch: master
          https://github.com/mongodb/mongo/commit/a0771ea5ec1b44537d3c409e3d712db24fd8e6bb

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'name': u'Ramon Fernandez', u'email': u'rfmnyc@gmail.com'} Message: Import wiredtiger-wiredtiger-mongodb-3.2.0-rc3-177-g9d375e3.tar.gz from wiredtiger branch mongodb-3.2 ref: d9ec1ff..9d375e3 16c0a1a WT-1315 Fix some leaks with join cursors. 59857f9 WT-2222 Add statistics for named snapshots. 4368d39 WT-1315 Cursor join implementation a72ddb7 WT-2218 Add truncate stats fb9cebe WT-2224 Track which deleted refs are discarded by a split. e2f1130 WT-2220 Split WT_TIMEDIFF macro into unit specific macros. be412b5 WT-2182 when internal pages grow large enough, split them into their parents ce8c091 WT-2219 Enhancements to in-memory testing 347d922 WT-2220 time_t cleanup. 08c0fcd WT-2217 change WT_CURSOR.insert to clear "set" key/value on return d1b5e7f WT-2135 Fix log_only setting for backup cursor. Fix initialization. 78bd4ac WT-2210 raw compression fails if row-store recovery precedes column-store recovery c1b2634 WT-2182 fixes for splitting up the tree. 0a1ee34 WT-2199 Fix transaction sync inconsistency. ee31bb2 WT-2182 Simplify the split deepen logic. c360d53 WT-2212 Add a "use_environment" config to "wiredtiger_open" 3f132a4 WT-2182 detect internal page split races. Branch: master https://github.com/mongodb/mongo/commit/a0771ea5ec1b44537d3c409e3d712db24fd8e6bb

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since reply:
                1 year, 27 weeks, 1 day ago
                Date of 1st Reply: