Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2227

cursor/cur_join.c lint

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Don, lint has some complaints about the new cursor join code – a couple of them look like real bugs.

      Let me know if I can help or if you need access to run lint.

      --- Module:   src/cursor/cur_join.c (C)
                                            _
      		c->get_key(c, &curkey);
      src/cursor/cur_join.c  315  Warning 534: Ignoring return value of function
          '__wt_cursor::get_key' (compare with line 224, file ./wiredtiger.h)
      ./wiredtiger.h  224  Info 830: Location cited in prior message
                                                        _
      			c->get_value(c, &curvalue);
      src/cursor/cur_join.c  351  Warning 534: Ignoring return value of function
          '__wt_cursor::get_value' (compare with line 238, file ./wiredtiger.h)
      ./wiredtiger.h  238  Info 830: Location cited in prior message
                                                      _
      			c->get_key(c, &curvalue);
      src/cursor/cur_join.c  353  Warning 534: Ignoring return value of function
          '__wt_cursor::get_key' (compare with line 224, file ./wiredtiger.h)
      ./wiredtiger.h  224  Info 830: Location cited in prior message
                                                                            _
      #... *lint -save -e636 */((void *)0)  /*lint -restore */, je->count, m, k, &je-
      				    NULL, je->count, m, k, &je->bloom));
      src/cursor/cur_join.c  478  Info 712: Loss of precision (arg. no. 5) (unsigned
          long long to unsigned int)
                                                                            _
      #... nt -save -e636 */((void *)0)  /*lint -restore */, je->count, m, k, &je->bl
      				    NULL, je->count, m, k, &je->bloom));
      src/cursor/cur_join.c  478  Info 712: Loss of precision (arg. no. 6) (unsigned
          long long to unsigned int)
                                                                       _
      #... oid *)0)  /*lint -restore */, je->count, je->bloom_bit_count, je->bloom_ha
      				    je->bloom_hash_count, &bloom));
      src/cursor/cur_join.c  504  Info 712: Loss of precision (arg. no. 5) (unsigned
          long long to unsigned int)
                                                                       _
      #... ore */, je->count, je->bloom_bit_count, je->bloom_hash_count, &bloom))) !=
      				    je->bloom_hash_count, &bloom));
      src/cursor/cur_join.c  504  Info 712: Loss of precision (arg. no. 6) (unsigned
          long long to unsigned int)
                                 _
      		c->reset(c);
      src/cursor/cur_join.c  661  Warning 534: Ignoring return value of function
          '__wt_cursor::reset' (compare with line 344, file ./wiredtiger.h)
      ./wiredtiger.h  344  Info 830: Location cited in prior message
                                                                          _
      #... ractor, &session->iface, key, &v, &extract_cursor.iface))) != 0) goto err;
      		    &session->iface, key, &v, &extract_cursor.iface));
      src/cursor/cur_join.c  673  Warning 645: Symbol 'v' (line 629) may not have
          been initialized
      src/cursor/cur_join.c  629  Info 830: Location cited in prior message
                                          _
      		entry->flags = flags;
      src/cursor/cur_join.c  950  Info 734: Loss of precision (assignment) (32 bits
          to 8 bits)
                                                               _
      		    F_ISSET(entry, WT_CURJOIN_ENTRY_BLOOM)) {
      src/cursor/cur_join.c  964  Info 731: Boolean argument to equal/not equal
                                 _
      #... (newend)->flags, range)
      	F_SET(newend, range);
      src/cursor/cur_join.c  1037  Info 734: Loss of precision (assignment) (32 bits
          to 8 bits)
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              donald.anderson Donald Anderson
              Reporter:
              keith.bostic Keith Bostic
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: