Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0
    • Labels:
      None
    • # Replies:
      7
    • Last comment by Customer:
      true

      Description

      The fix for WT-2237 caused a performance regression on some multi-threaded update workloads.

        Issue Links

          Activity

          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: WT-2241 Use a lock to protect transaction ID allocation.

          We still need to make sure that transaction IDs are published in the state
          table before the current ID is incremented so that snapshot reads don't see
          uncommitted updates. However, a lock simplifies the code and performs better
          in testing than the initial fix.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/5a51b154c6d27a1fd75377385bec69fa996b59da

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: WT-2241 Use a lock to protect transaction ID allocation. We still need to make sure that transaction IDs are published in the state table before the current ID is incremented so that snapshot reads don't see uncommitted updates. However, a lock simplifies the code and performs better in testing than the initial fix. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/5a51b154c6d27a1fd75377385bec69fa996b59da
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Merge pull request #2337 from wiredtiger/WT-2241

          WT-2241 Use a lock to protect transaction ID allocation.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/6c7338f2e62d74d59d590a6712eb7e55f2586a8a

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2337 from wiredtiger/ WT-2241 WT-2241 Use a lock to protect transaction ID allocation. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/6c7338f2e62d74d59d590a6712eb7e55f2586a8a
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Merge pull request #2337 from wiredtiger/WT-2241

          WT-2241 Use a lock to protect transaction ID allocation.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/6c7338f2e62d74d59d590a6712eb7e55f2586a8a

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2337 from wiredtiger/ WT-2241 WT-2241 Use a lock to protect transaction ID allocation. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/6c7338f2e62d74d59d590a6712eb7e55f2586a8a
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Import wiredtiger-wiredtiger-mongodb-3.2-rc4-41-g8326df6.tar.gz from wiredtiger branch mongodb-3.2

          ref: b65381f..8326df6

          4c49948 WT-2244 Trigger in-memory splits sooner.
          9f2e4f3 WT-2248 WT_SESSION.close is updating WT_CONNECTION_IMPL.default_session.
          a6da10e SERVER-21553 Enable fast-path truncate after splits.
          39dfd21 WT-2243 Don't keep transaction IDs pinned for reading from checkpoints.
          4e1844c WT-2230 multi-split error path.
          cace179 WT-2228 avoid unnecessary raw-compression calls.
          890ee34 SERVER-21619 Don't do internal page splits after a tree is marked DEAD.
          6c7338f WT-2241 Use a lock to protect transaction ID allocation.
          978c237 WT-2234 Coverity analysis warnings.
          Branch: master
          https://github.com/mongodb/mongo/commit/e7181b542b25981db42f74cdaee4e7fc323d3e9d

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Import wiredtiger-wiredtiger-mongodb-3.2-rc4-41-g8326df6.tar.gz from wiredtiger branch mongodb-3.2 ref: b65381f..8326df6 4c49948 WT-2244 Trigger in-memory splits sooner. 9f2e4f3 WT-2248 WT_SESSION.close is updating WT_CONNECTION_IMPL.default_session. a6da10e SERVER-21553 Enable fast-path truncate after splits. 39dfd21 WT-2243 Don't keep transaction IDs pinned for reading from checkpoints. 4e1844c WT-2230 multi-split error path. cace179 WT-2228 avoid unnecessary raw-compression calls. 890ee34 SERVER-21619 Don't do internal page splits after a tree is marked DEAD. 6c7338f WT-2241 Use a lock to protect transaction ID allocation. 978c237 WT-2234 Coverity analysis warnings. Branch: master https://github.com/mongodb/mongo/commit/e7181b542b25981db42f74cdaee4e7fc323d3e9d
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Merge pull request #2337 from wiredtiger/WT-2241

          WT-2241 Use a lock to protect transaction ID allocation.

          (cherry picked from commit 6c7338f2e62d74d59d590a6712eb7e55f2586a8a)
          Branch: mongodb-3.0
          https://github.com/wiredtiger/wiredtiger/commit/03985157328c9f29f8f575a03e0023e38ed9bd4c

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2337 from wiredtiger/ WT-2241 WT-2241 Use a lock to protect transaction ID allocation. (cherry picked from commit 6c7338f2e62d74d59d590a6712eb7e55f2586a8a) Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/03985157328c9f29f8f575a03e0023e38ed9bd4c
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Merge pull request #2337 from wiredtiger/WT-2241

          WT-2241 Use a lock to protect transaction ID allocation.

          (cherry picked from commit 6c7338f2e62d74d59d590a6712eb7e55f2586a8a)
          Branch: mongodb-3.0
          https://github.com/wiredtiger/wiredtiger/commit/03985157328c9f29f8f575a03e0023e38ed9bd4c

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2337 from wiredtiger/ WT-2241 WT-2241 Use a lock to protect transaction ID allocation. (cherry picked from commit 6c7338f2e62d74d59d590a6712eb7e55f2586a8a) Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/03985157328c9f29f8f575a03e0023e38ed9bd4c
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Import wiredtiger-wiredtiger-mongodb-3.0.7-20-g27d0cbd.tar.gz from wiredtiger branch mongodb-3.0

          ref: deb2d81..27d0cbd

          6feaa28 WT-2251 Fix leaf of deleted page addresses.
          1da2d3a SERVER-21568 Fix a use-after-free.
          4228295 SERVER-21553 Free blocks during reverse splits.
          0398515 WT-2241 Use a lock to protect transaction ID allocation.
          06a5c7b WT-2237 Avoid yields if we race allocating transaction IDs.
          16a418b WT-2237 Have threads publish unique transaction IDs so that updates always become visible immediately on commit.
          Branch: v3.0
          https://github.com/mongodb/mongo/commit/eb8bc24a0d36b673022faa83976a4b33bc8f676b

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Import wiredtiger-wiredtiger-mongodb-3.0.7-20-g27d0cbd.tar.gz from wiredtiger branch mongodb-3.0 ref: deb2d81..27d0cbd 6feaa28 WT-2251 Fix leaf of deleted page addresses. 1da2d3a SERVER-21568 Fix a use-after-free. 4228295 SERVER-21553 Free blocks during reverse splits. 0398515 WT-2241 Use a lock to protect transaction ID allocation. 06a5c7b WT-2237 Avoid yields if we race allocating transaction IDs. 16a418b WT-2237 Have threads publish unique transaction IDs so that updates always become visible immediately on commit. Branch: v3.0 https://github.com/mongodb/mongo/commit/eb8bc24a0d36b673022faa83976a4b33bc8f676b

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since reply:
                1 year, 16 weeks, 1 day ago
                Date of 1st Reply: