Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2369

Use C compiler to detect headers instead of C++ compiler

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Minor - P4
        • Resolution: Fixed
        • Affects Version/s: WT2.7.0
        • Fix Version/s: WT2.8.0
        • Labels:
          None
        • Sprint:
          Platforms 10 (02/19/16)

          Description

          WiredTiger's options.m4 uses the C++ compiler instead of the C compiler to check for several C headers:

          • snappy.h
          • lz4.h
          • gperftools/tcmalloc.h

          snappy.h is a C++ header while snappy-c.h is the C equivalent, and the one included by snappy_compress.c.

            Issue Links

            is depended on by

            Improvement - An improvement or enhancement to an existing feature or task. SERVER-22388 WiredTiger changes for MongoDB 3.3.2

            • Major - P3 - Major loss of function.
            • Closed

            Improvement - An improvement or enhancement to an existing feature or task. SERVER-22570 WiredTiger changes for MongoDB 3.2.4

            • Major - P3 - Major loss of function.
            • Closed

              Activity

              • Comments
              Ascending order - Click to sort in descending order
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

              Message: WT-2369 Use C compiler to detect headers instead of C++ compiler
              Branch: develop
              https://github.com/wiredtiger/wiredtiger/commit/a679c103fcbb7473ae8a4f83f0cdd6023ddff651

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'} Message: WT-2369 Use C compiler to detect headers instead of C++ compiler Branch: develop https://github.com/wiredtiger/wiredtiger/commit/a679c103fcbb7473ae8a4f83f0cdd6023ddff651
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith.bostic@mongodb.com'}

              Message: Merge pull request #2468 from wiredtiger/wt-2369-improve-options-m4

              WT-2369 Use C compiler to detect headers instead of C++ compiler
              Branch: develop
              https://github.com/wiredtiger/wiredtiger/commit/0b84545c4f26f0a10fca14016f9b736ce56ee3b6

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith.bostic@mongodb.com'} Message: Merge pull request #2468 from wiredtiger/wt-2369-improve-options-m4 WT-2369 Use C compiler to detect headers instead of C++ compiler Branch: develop https://github.com/wiredtiger/wiredtiger/commit/0b84545c4f26f0a10fca14016f9b736ce56ee3b6
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexg@wiredtiger.com'}

              Message: Import wiredtiger-wiredtiger-2.7.0-592-gcc96d99.tar.gz from wiredtiger branch mongodb-3.4

              ref: 7fea169..cc96d99

              WT-60 Big endian port
              WT-2130 Improve on-disk page utlilization with random workloads
              WT-2215 WT_LSN needs to support atomic reads and updates
              WT-2295 WT_SESSION.create does a full-scan of the main table
              WT-2352 Allow build and test without requiring lz4
              WT-2356 Log scan advances to next log file on partially written record
              WT-2363 Remove built in support for bzip2
              WT-2368 Row-store can pass garbage keys to collator functions
              WT-2369 Use C compiler to detect headers instead of C++ compiler
              WT-2371 Parent split cannot access the page after page-index swap
              WT-2372 WiredTiger windows builder fails with C4005 against the "inline" macro
              WT-2377 WTPERF doesn't compile in Windows under MSVC
              WT-2378 Tasks time out on LSM builder
              SERVER-22388 WiredTiger changes for MongoDB 3.3.2
              SERVER-22437 Coverity analysis defect 77704: Redundant test
              SERVER-22438 Coverity analysis defect 77705: Dereference before null check
              Branch: master
              https://github.com/mongodb/mongo/commit/79a378bddf664714190dc9d0a34b1d8cd4951588

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexg@wiredtiger.com'} Message: Import wiredtiger-wiredtiger-2.7.0-592-gcc96d99.tar.gz from wiredtiger branch mongodb-3.4 ref: 7fea169..cc96d99 WT-60 Big endian port WT-2130 Improve on-disk page utlilization with random workloads WT-2215 WT_LSN needs to support atomic reads and updates WT-2295 WT_SESSION.create does a full-scan of the main table WT-2352 Allow build and test without requiring lz4 WT-2356 Log scan advances to next log file on partially written record WT-2363 Remove built in support for bzip2 WT-2368 Row-store can pass garbage keys to collator functions WT-2369 Use C compiler to detect headers instead of C++ compiler WT-2371 Parent split cannot access the page after page-index swap WT-2372 WiredTiger windows builder fails with C4005 against the "inline" macro WT-2377 WTPERF doesn't compile in Windows under MSVC WT-2378 Tasks time out on LSM builder SERVER-22388 WiredTiger changes for MongoDB 3.3.2 SERVER-22437 Coverity analysis defect 77704: Redundant test SERVER-22438 Coverity analysis defect 77705: Dereference before null check Branch: master https://github.com/mongodb/mongo/commit/79a378bddf664714190dc9d0a34b1d8cd4951588
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

              Message: WT-2369 Use C compiler to detect headers instead of C++ compiler
              Branch: mongodb-3.2
              https://github.com/wiredtiger/wiredtiger/commit/a679c103fcbb7473ae8a4f83f0cdd6023ddff651

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'} Message: WT-2369 Use C compiler to detect headers instead of C++ compiler Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/a679c103fcbb7473ae8a4f83f0cdd6023ddff651
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith.bostic@mongodb.com'}

              Message: Merge pull request #2468 from wiredtiger/wt-2369-improve-options-m4

              WT-2369 Use C compiler to detect headers instead of C++ compiler
              Branch: mongodb-3.2
              https://github.com/wiredtiger/wiredtiger/commit/0b84545c4f26f0a10fca14016f9b736ce56ee3b6

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith.bostic@mongodb.com'} Message: Merge pull request #2468 from wiredtiger/wt-2369-improve-options-m4 WT-2369 Use C compiler to detect headers instead of C++ compiler Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/0b84545c4f26f0a10fca14016f9b736ce56ee3b6
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

              Message: WT-2369 Use C compiler to detect headers instead of C++ compiler
              Branch: mongodb-3.2
              https://github.com/wiredtiger/wiredtiger/commit/a679c103fcbb7473ae8a4f83f0cdd6023ddff651

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'} Message: WT-2369 Use C compiler to detect headers instead of C++ compiler Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/a679c103fcbb7473ae8a4f83f0cdd6023ddff651
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith.bostic@mongodb.com'}

              Message: Merge pull request #2468 from wiredtiger/wt-2369-improve-options-m4

              WT-2369 Use C compiler to detect headers instead of C++ compiler
              Branch: mongodb-3.2
              https://github.com/wiredtiger/wiredtiger/commit/0b84545c4f26f0a10fca14016f9b736ce56ee3b6

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith.bostic@mongodb.com'} Message: Merge pull request #2468 from wiredtiger/wt-2369-improve-options-m4 WT-2369 Use C compiler to detect headers instead of C++ compiler Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/0b84545c4f26f0a10fca14016f9b736ce56ee3b6
              Hide
              Permalink
              xgen-internal-githook Githook User added a comment -

              Author:

              {u'name': u'Ramon Fernandez', u'email': u'ramon@mongodb.com'}

              Message: Import wiredtiger-wiredtiger-2.7.0-650-g5cdd3e3.tar.gz from wiredtiger branch mongodb-3.2

              ref: 07966a4..5cdd3e3

              SERVER-22437 Coverity analysis defect 77704: Redundant test
              SERVER-22438 Coverity analysis defect 77705: Dereference before null check
              SERVER-22676 WiredTiger fails to open databases created by 3.0.0 or 3.0.1
              WT-2130 Improve on-disk page utlilization with random workloads
              WT-2215 WT_LSN needs to support atomic reads and updates
              WT-2295 WT_SESSION.create does a full-scan of the main table
              WT-2352 Allow build and test without requiring lz4
              WT-2356 log scan advances to next log file on partially written record
              WT-2363 Remove built in support for bzip2
              WT-2368 row-store can pass garbage keys to collator functions
              WT-2369 Use C compiler to detect headers instead of C++ compiler
              WT-2371 parent split cannot access the page after page-index swap
              WT-2372 WiredTiger windows builder fails with C4005 against the "inline" macro
              WT-2377 WTPERF doesn't compile in Windows under MSVC
              WT-2378 Tasks time out on LSM builder
              WT-2397 Cursor traversal from end of the tree skips records.
              WT-60 Big endian port
              Branch: v3.2
              https://github.com/mongodb/mongo/commit/f77630a9e971cae1f921292ea31d9d40a4b096b8

              Show
              xgen-internal-githook Githook User added a comment - Author: {u'name': u'Ramon Fernandez', u'email': u'ramon@mongodb.com'} Message: Import wiredtiger-wiredtiger-2.7.0-650-g5cdd3e3.tar.gz from wiredtiger branch mongodb-3.2 ref: 07966a4..5cdd3e3 SERVER-22437 Coverity analysis defect 77704: Redundant test SERVER-22438 Coverity analysis defect 77705: Dereference before null check SERVER-22676 WiredTiger fails to open databases created by 3.0.0 or 3.0.1 WT-2130 Improve on-disk page utlilization with random workloads WT-2215 WT_LSN needs to support atomic reads and updates WT-2295 WT_SESSION.create does a full-scan of the main table WT-2352 Allow build and test without requiring lz4 WT-2356 log scan advances to next log file on partially written record WT-2363 Remove built in support for bzip2 WT-2368 row-store can pass garbage keys to collator functions WT-2369 Use C compiler to detect headers instead of C++ compiler WT-2371 parent split cannot access the page after page-index swap WT-2372 WiredTiger windows builder fails with C4005 against the "inline" macro WT-2377 WTPERF doesn't compile in Windows under MSVC WT-2378 Tasks time out on LSM builder WT-2397 Cursor traversal from end of the tree skips records. WT-60 Big endian port Branch: v3.2 https://github.com/mongodb/mongo/commit/f77630a9e971cae1f921292ea31d9d40a4b096b8

                People

                • Assignee:
                  mark.benvenuto Mark Benvenuto
                  Reporter:
                  mark.benvenuto Mark Benvenuto
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                      Agile