Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2380

Make scripts fail if code doesn't match style

    XMLWordPrintable

    Details

      Description

      I pushed a branch that had an extra blank line. So s_whitespace removed it and pull-request-tester failed due to the modified file. While looking at it, I noticed that s_all had two other failures, one from s_define and s_longlines, both from files I did not touch.

      Basically s_all is not failing Jenkins for those kinds of things and so if we don't notice them and the pull-request-tester passes we merge them into develop.

      For this particular case, it is shown in the original log:
      http://build.wiredtiger.com:8080/job/wiredtiger-pull-request-tester/5511/consoleFull

      It was from this PR:
      https://github.com/wiredtiger/wiredtiger/pull/2476

      My minor fixes today are:
      https://github.com/wiredtiger/wiredtiger/pull/2482

      It doesn't look like s_all:errchk results in a non-zero exit status.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                david.hows David Hows
                Reporter:
                michael.cahill Michael Cahill
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: