Details
Bug
Minor - P4
Description
Statistics macros update all statistics even when statistics is set to none/fast/all. none/fast/all makes a difference in how the stats_cursor collects the statistics when these statistics get reported.
Fix macros to not update any stats when statistics=none is set.
Also, rename macros to reflect that there is no difference in fast/all wrt updating stats.
Issue Links
Activity
Author:
{u'username': u'sulabhM', u'name': u'Sulabh Mahajan', u'email': u'sulabh.mahajan@mongodb.com'}Message: WT-2859 Restructure statistics gathering macros (#3016)
Having FAST macros gives an impression that when we use them,
we are collecting fast statistics only, which is not true.
Except when statistics=none is set, we collect all the stats.
This change removes FAST macros and modifies the basic macros
to only collect stats when statistics=none is not set.
Branch: develop
https://github.com/wiredtiger/wiredtiger/commit/e189aa8a3de76fcd71a4dea254a24f02c80dfa19
Author:
{u'username': u'sulabhM', u'name': u'Sulabh Mahajan', u'email': u'sulabh.mahajan@mongodb.com'}Message: WT-2859 Restructure statistics gathering macros (#3016)
Having FAST macros gives an impression that when we use them,
we are collecting fast statistics only, which is not true.
Except when statistics=none is set, we collect all the stats.
This change removes FAST macros and modifies the basic macros
to only collect stats when statistics=none is not set.
Branch: mongodb-3.4
https://github.com/wiredtiger/wiredtiger/commit/e189aa8a3de76fcd71a4dea254a24f02c80dfa19
Author:
{u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexander.gorrod@mongodb.com'}Message: Import wiredtiger: 5bc03723a7e77c96b1d5e45a97173654872c727a from branch mongodb-3.4
ref: deeb0f589a..5bc03723a7
for: 3.3.13
WT-2859 Improve statistics macros to not collect stats when statistics=none is set
WT-2894 Create workload that shows negative scaling when overwhelmed
WT-2900 Add ARM8 build support to WiredTiger and fix ARM CRC assembler tags
WT-2902 Enhance eviction to work better with update heavy YCSB load
WT-2905 dead code: MongoDB Coverity #99881
WT-2908 Add dry-run support to python unit-test
WT-2910 test_inmem01 can abort due to stuck cache
WT-2911 add support for gcc6
WT-2912 make --enable-strict run on the zseries test box
WT-2913 stuck cache after latest merge
WT-2914 Fix link error on OS/X for checksum_init call
WT-2916 whitespace check not working
Branch: master
https://github.com/mongodb/mongo/commit/7693fa59c4470db729d85af99fb9cc3b264fa8c8
Author:
{u'username': u'sulabhM', u'name': u'Sulabh Mahajan', u'email': u'sulabh.mahajan@mongodb.com'}Message: WT-2859 Restructure statistics gathering macros (#3016)
Having FAST macros gives an impression that when we use them,
we are collecting fast statistics only, which is not true.
Except when statistics=none is set, we collect all the stats.
This change removes FAST macros and modifies the basic macros
to only collect stats when statistics=none is not set.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/e189aa8a3de76fcd71a4dea254a24f02c80dfa19
Author:
{u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}Message: Import wiredtiger: bb18c439152379fb528af217345be40819b01fc4 from branch mongodb-3.2
ref: 911c940ada..bb18c43915
for: 3.2.10
WT-2859 Improve statistics macros to not collect stats when statistics=none is set
WT-2894 Create workload that shows negative scaling when overwhelmed
WT-2900 Add ARM8 build support to WiredTiger and fix ARM CRC assembler tags
WT-2902 Enhance eviction to work better with update heavy YCSB load
WT-2905 dead code: MongoDB Coverity #99881
WT-2908 Add dry-run support to python unit-test
WT-2910 test_inmem01 can abort due to stuck cache
WT-2911 add support for gcc6
WT-2912 make --enable-strict run on the zseries test box
WT-2913 stuck cache after latest merge
WT-2914 Fix link error on OS/X for checksum_init call
WT-2916 whitespace check not working
Branch: v3.2
https://github.com/mongodb/mongo/commit/dfca65ea3a32b1e0c832ff7ee2d7b667819ec64d
There is a lot of general discussion about this change in the PR that probably should've been here. https://github.com/wiredtiger/wiredtiger/pull/3016.