Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-3174

Coverity/lint cleanup

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial - P5
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.9.2, 3.2.13, 3.4.3, 3.5.4
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Storage 2017-02-13

      Description

      Coverity 1371132: Logically dead code (DEADCODE)

      In bt_split.c:

      677        /* Adjust the root's memory footprint and mark it dirty. */
      678        __wt_cache_page_inmem_incr(session, root, root_incr);
      679        __wt_cache_page_inmem_decr(session, root, root_decr);
      680        __wt_page_modify_set(session, root);
      681
         	intervals: When switching on complete, the value of complete must be in one of the following intervals: {[0,0], [2,2]}.
      682err:    switch (complete) {
      683        case WT_ERR_RETURN:
      684                __wt_free_ref_index(session, root, alloc_index, true);
      685                break;
         	dead_error_condition: The switch value complete cannot be WT_ERR_PANIC.
      	CID 1371132 (#1 of 1): Logically dead code (DEADCODE)
      	dead_error_begin: Execution cannot reach this statement: case WT_ERR_PANIC:.
      686        case WT_ERR_PANIC:
      687                __wt_err(session, ret,
      688                    "fatal error during root page split to deepen the tree");
      689                ret = WT_PANIC;
      690                break;
      691        case WT_ERR_IGNORE:
      692                if (ret != 0 && ret != WT_PANIC) {
      693                        __wt_err(session, ret,
      694                            "ignoring not-fatal error during root page split "
      695                            "to deepen the tree");
      696                        ret = 0;
      697                }
      698                break;
      699        }
      700        return (ret);
      

        Attachments

          Activity

            People

            • Assignee:
              keith.bostic Keith Bostic
              Reporter:
              keith.bostic Keith Bostic
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: