Details
Minor - P4 Description
This code to dump the cache state in evict_lru.c has undefined behavior:
WT_RET(__wt_msg(session, "cache clean check: %s (%u%%)",
|
__wt_eviction_clean_needed(session, &pct) ? "yes" : "no", pct));
|
In particular, it expects that the function setting pct completes before the value of pct is passed to __wt_msg.
It would be better as:
needed = __wt_eviction_clean_needed(session, &pct);
|
WT_RET(__wt_msg(session, "cache clean check: %s (%u%%)",
|
needed ? "yes" : "no", pct));
|
Review the code for similar issues.