-
Type: Task
-
Resolution: Done
-
Affects Version/s: None
-
Component/s: None
-
None
Michael, I had a clean-up item that was waiting on your stats commit, to fix up the line between the btree and block-manager statistics. While I was in there, I decided I liked the way Alex broke out the LSM statistics, so I kind of went wild.
The only "interesting" things:
1. I changed it so we're maintaining roughly the same information in both the connection and data-source cache statistics. For example, previously we were tracking "evicted pages" for the data-source in bt_evict.c, and "clean evictions" plus "dirty evictions" for the connection in rec_evict.c, and there were a couple of other similar-but-not-quite-the-same fields.
I changed evicted page tracking to be the same (clean & dirty in both cases), and moved all the statistics gathering into rec_evict.c.
The other changes were pretty simple naming changes, or tracking various statistics in both the connection and the data-source (rather than in just one of them).
2. I renamed the cursor statistics to match the cursor method names.
3. I made the split between the btree and block manager statistics cleaner: it's now block_XXX and btree_XXX (it used to be file_XXX for both).
Anyway, if you hate it, let me know and I'll go back and do just the minimal change, otherwise please pull it in.