-
Type: Task
-
Resolution: Done
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
Hi Michael,
I've made some changes to the error handling. I think they are definite improvements. I've got two remaining concerns, I wanted to check in to ensure they are valid before I chase them down (hence the pull request).
1) Should drop and rename be updating the WT_CONNECTION::lsmqh queue? If so, would that belong in the lsm_dsrc.c:*lsm_drop and lsm_dsrc.c:*lsm_rename functions?
2) I'm concerned about the state of things if a call to *lsm_tree_close (or any subsequent calls in the schema level functions) fails. At that stage, I suspect we really want to free any resources we can and remove the LSM tree from the connection list (so a new one can be created). Alternatively, do we need a call to *lsm_tree_start_worker in the error handling code?