Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-4133

Coverity 1393445, 1393446 Dereference before null check

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6.9, 4.0.1, 4.1.1, WT3.2.0
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Storage Non-NYC 2018-06-18

      Description

       785        /*
       786         * Default to not skipping - also initialize the other output
       787         * parameters - even though they will always be initialized unless
       788         * there is an error and callers need to ignore the results on error.
       789         */
          	deref_ptr: Directly dereferencing pointer fullp.
       790        *can_skipp = *fullp = *use_timestampp = false;
       791
       792        conn = S2C(session);
       793        txn_global = &conn->txn_global;
       794
       795        /*
       796         * This function also parses out some configuration options and hands
       797         * them back to the caller - make sure it does that parsing regardless
       798         * of the result.
       799         *
       800         * Determine if this is going to be a full checkpoint, that is a
       801         * checkpoint that applies to all data tables in a database.
       802         */
       803        WT_RET(__wt_config_gets(session, cfg, "target", &cval));
       804        __wt_config_subinit(session, &targetconf, &cval);
       805        full = __wt_config_next(&targetconf, &k, &v) != 0;
          	
      CID 1393446 (#1 of 1): Dereference before null check (REVERSE_INULL)
      check_after_deref: Null-checking fullp suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
       806        if (fullp != NULL)
       807                *fullp = full;
       808
       809        WT_RET(__wt_config_gets(session, cfg, "use_timestamp", &cval));
       810        use_timestamp = cval.val != 0;
       
      CID 1393445: Dereference before null check (REVERSE_INULL)
       811        if (use_timestampp != NULL)
       812                *use_timestampp = use_timestamp;
       813
      

        Attachments

          Activity

            People

            Assignee:
            keith.bostic Keith Bostic
            Reporter:
            keith.bostic Keith Bostic
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: