Details
Major - P3 Description
It looks the recent Python3 change (WT-4695) triggered the application of a stricter Python formatting standard, which failed the "s_all" verification as below, on one of our development environments.
Please note the problem needs a code compilation to surface. Jenkins pull request test (wiredtiger-pull-request-builds) did not fail, as the "s_all" verification is currently set to execute without a prior compilation step.
$ ./s_all
|
dist/s_all run started...
|
Updating files that include the package version
|
File "tools/fixlinks.py", line 62
|
source = re.sub(r'(\s+#.*self),
|
^
|
SyntaxError: EOL while scanning string literal
|
####################### MESSAGE ############################
|
s_all run of: "./s_python" resulted in:
|
[tab] characters appear in Python scripts:
|
./lang/python/wiredtiger.py
|
#######################
|
####################### MESSAGE ############################
|
s_all run of: "./s_win" resulted in:
|
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
|
../build_win/wiredtiger_config.h: configuration #defines do not match POSIX
|
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
|
HAVE_TIMER_CREATE
|
#######################
|
dist/s_all run finished
|
We should either fix above errors picked up by the 'stricter' Python formatting standard, or revert to the previous checking standard and coordinate a smoother enabling of the 'stricter' formatting standard.
The Jenkins pull request test needs to be evaluated/enhanced to be able to catch such errors in the future.