Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-4810

Adding WT_ERR_ASSERT and WT_RET_ASSERT macros

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.1, WT3.2.1, 4.3.1
    • Component/s: None
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Storage Engines 2019-08-26

      Description

      It is better to have a reason string to WT_ASSERT, similar to WT_ERR_MSG to improve diagnosability.

      Sometimes it is not very clear for the assertion reason.  

      one example is https://github.com/mongodb/mongo/blob/e9753b56fe3f7e5c3e783f31d3ed5fe7afb8f641/src/third_party/wiredtiger/src/txn/txn.c#L1083

      Instead of forcing every WT_ASSERT to accept a "reason", we can have a new construct WT_ASSERT_MSG which accepts assert condition and asserting reason.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              luke.pearson Luke Pearson
              Reporter:
              vamsi.krishna Vamsi Boyapati
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: