Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-4946

Tighten up failure checks for cursor join

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.1, WT3.2.1, 4.3.1
    • Component/s: None
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Storage Engines 2019-07-29, Storage Engines 2019-08-12

      Description

      Keith Bostic reports: in _curjoin_entry_member() there's this code:

      WT_ASSERT(session,
          iter == NULL || entry->subjoin == iter->child->cjoin);
      ret = __curjoin_entries_in_range(session, entry->subjoin,
          key, iter == NULL ? NULL : iter->child);
      if (iter != NULL && 
          WT_CURJOIN_ITER_CONSUMED(iter->child)) {
              WT_ERR(__curjoin_iter_bump(iter));
              ret = WT_NOTFOUND;
      }       
      return (ret);
      

      Should that final return be WT_ERR(ret); instead, because __curjoin_entries_in_range returns WT_NOTFOUND.

        Attachments

          Activity

            People

            Assignee:
            donald.anderson Donald Anderson
            Reporter:
            donald.anderson Donald Anderson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: