Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-5135

Change lookaside file inserts to use cursor.insert

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.1, WT3.2.2, 4.2.2, 3.6.17, 4.0.15
    • Component/s: None
    • Labels:
      None
    • Story Points:
      5
    • Sprint:
      Storage Engines 2019-10-07
    • Backport Requested:
      v4.0, v3.6

      Description

      The code to insert items into the lookaside table was changed from using WT_CURSOR.insert to using WT_CURSOR.update, with the expectation that WT_CURSOR.update would search any currently pinned leaf page before searching the tree. It was thought that would be a faster point update for the lookaside table as it's generally appending to a single page at the end of the tree.

      That wasn't correct. Because the lookaside insert code "sets" the key (using WT_CURSOR.set_key), any pinned page information is ignored, and a full tree search is performed.

      Because WT_CURSOR.insert holds resources for a shorter period than WT_CURSOR.update, we should switch back to using WT_CURSOR.insert, it should make lookaside table operations somewhat less resource intensive.

      See commit 30c226f.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              keith.bostic Keith Bostic
              Reporter:
              keith.bostic Keith Bostic
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: