Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-5499

Replace lookaside score statistic with something similar

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major - P3
    • Resolution: Gone away
    • None
    • None
    • None
    • None
    • 5

    Description

      We recently removed the lookaside file from WiredTiger as durable history replaces it. MongoDB relies on a particular statistic to make decisions about how much cache pressure WiredTiger is experiencing. We removed that statistic, and will need to update MongoDB prior to merging this change there, so it no longer uses the stat.

      Compilation failure:

      [2020/01/30 15:11:11.160] In file included from src/mongo/bson/bson_comparator_interface_base.h:40,
      		 
      [2020/01/30 15:11:11.160]                  from src/mongo/bson/bsonobj.h:43,
      		 
      [2020/01/30 15:11:11.160]                  from src/mongo/db/storage/wiredtiger/wiredtiger_util.h:37,
      		 
      [2020/01/30 15:11:11.160]                  from src/mongo/db/storage/wiredtiger/wiredtiger_util.cpp:34:
      		 
      [2020/01/30 15:11:11.160] src/mongo/db/storage/wiredtiger/wiredtiger_util.cpp: In static member function 'static void mongo::WiredTigerUtil::appendSnapshotWindowSettings(mongo::WiredTigerKVEngine*, mongo::WiredTigerSession*, mongo::BSONObjBuilder*)':
      		 
      [2020/01/30 15:11:11.160] src/mongo/db/storage/wiredtiger/wiredtiger_util.cpp:709:51: error: 'WT_STAT_CONN_CACHE_LOOKASIDE_SCORE' was not declared in this scope
      		 
      [2020/01/30 15:11:11.160]          session->getSession(), "statistics:", "", WT_STAT_CONN_CACHE_LOOKASIDE_SCORE));
      		 
      [2020/01/30 15:11:11.160]                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      		 
      [2020/01/30 15:11:11.160] src/mongo/util/assert_util.h:377:67: note: in definition of macro 'uassertStatusOK'
      		 
      [2020/01/30 15:11:11.160]  #define uassertStatusOK(...) ::mongo::uassertStatusOKWithLocation(__VA_ARGS__, __FILE__, __LINE__)
      		 
      [2020/01/30 15:11:11.160]                                                                    ^~~~~~~~~~~
      		 
      [2020/01/30 15:11:11.172] src/mongo/db/storage/wiredtiger/wiredtiger_util.cpp:709:51: note: suggested alternative: 'WT_STAT_CONN_CACHE_HS_SCORE'
      		 
      [2020/01/30 15:11:11.172]          session->getSession(), "statistics:", "", WT_STAT_CONN_CACHE_LOOKASIDE_SCORE));
      		 
      [2020/01/30 15:11:11.172]                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      		 
      [2020/01/30 15:11:11.172] src/mongo/util/assert_util.h:377:67: note: in definition of macro 'uassertStatusOK'
      		 
      [2020/01/30 15:11:11.172]  #define uassertStatusOK(...) ::mongo::uassertStatusOKWithLocation(__VA_ARGS__, __FILE__, __LINE__)
      		 
      [2020/01/30 15:11:11.172]                                                                    ^~~~~~~~~~~

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. SERVER-50776 Complete TODO listed in WT-5585

          • Major - P3 - Major loss of function.
          • Backlog

          Technical Debt - WT-8012 Remove unused cache_lookaside_score and cache_hs_score stats

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          related to

          Task - A task that needs to be done. SERVER-46150 Disable unit test CreateAndCheckForCachePressure

          • Major - P3 - Major loss of function.
          • Closed

          Task - A task that needs to be done. WT-5576 Temporarily add lookaside score stat and cache_overflow config option

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              backlog-server-storage-engines Backlog - Storage Engines Team
              alexander.gorrod@mongodb.com Alexander Gorrod
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: