Do not use default session to create a history store cursor when configuring

XMLWordPrintableJSON

    • Storage Engines 2020-02-10, Storage Engines 2020-02-24
    • 5

      WT-5467 got rid of the cursor pool, but that required a default session to create a history store cursor to configure/reconfigure the history store. Doing so requires a hack to temporarily disable opening of new dhandles from the default session.

      This ticket will find an alternate way to configure without opening a history store cursor from a default session.

      For reference:

      Review comment from the change: https://github.com/wiredtiger/wiredtiger/pull/5188/files/ebfbe2a1d513ff89f99f82c855860e46e8c82a06#r372772870

      The change:

          /*
     * Retrieve the btree from the history store cursor. This function might need to open a cursor
     * from the default session and hence need to flip the no-dhandle flag temporarily in case it is
     * set.
     */
    if (F_ISSET(session, WT_SESSION_NO_DATA_HANDLES)) {
        reset_no_dh_flag = true;
        F_CLR(session, WT_SESSION_NO_DATA_HANDLES);
    }
    WT_ERR(__wt_hs_get_btree(session, &btree));
    WT_ASSERT(session, btree != NULL);

            Assignee:
            Haseeb Bokhari (Inactive)
            Reporter:
            Sulabh Mahajan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: