Details
Description
One of my PRs failed on Windows in test_checkpoint04.py with:
[2020/05/21 20:13:50.715] ======================================================================
|
[2020/05/21 20:13:50.715] FAIL: test_checkpoint04.test_checkpoint04.test_checkpoint_stats
|
[2020/05/21 20:13:50.715] ----------------------------------------------------------------------
|
[2020/05/21 20:13:50.715] Traceback (most recent call last):
|
[2020/05/21 20:13:50.715] File "C:\data\mci\aa021dc9995f8f691da1fbcbeab1aa67\wiredtiger\test\suite\test_checkpoint04.py", line 124, in test_checkpoint_stats
|
[2020/05/21 20:13:50.715] self.assertLess(prep_min, time_min)
|
[2020/05/21 20:13:50.715] AssertionError: 0 not less than 0
|
[2020/05/21 20:13:50.715] ----------------------------------------------------------------------
|
The test assumes the time needed is measurable and Windows often has very coarse timings.
self.assertLess(prep_min, time_min)
|
self.assertLess(prep_max, time_max)
|
self.assertLess(prep_recent, time_recent)
|
self.assertLess(prep_total, time_total)
|
These should either accept assertLessEqual or specifically check for 0.