-
Type:
Bug
-
Resolution: Unresolved
-
Priority:
Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
I think we can get rid of this memory copy as the comment suggested in __wt_hs_find_upd:
/*
* Potential optimization: We can likely get rid of this copy and the update allocation above.
* We already have buffers containing the modify values so there's no good reason to allocate an
* update other than to work with our modify vector implementation.
*/
WT_ERR(__wt_buf_set(session, &upd_value->buf, hs_value->data, hs_value->size));
The upd_value->bug should have been pointing to the onpage value when we enter this function. We can resolve modify directly using that buffer. I attempted once but there are failing tests. I didn't bother to spend more time on that as we were close to the release.