Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-6459

Remove the extra memory copy in __wt_find_hs_upd

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: None
    • Labels:
      None

      Description

      I think we can get rid of this memory copy as the comment suggested in __wt_find_hs_upd:

          /*
           * Potential optimization: We can likely get rid of this copy and the update allocation above.
           * We already have buffers containing the modify values so there's no good reason to allocate an
           * update other than to work with our modify vector implementation.
           */
          WT_ERR(__wt_buf_set(session, &upd_value->buf, hs_value->data, hs_value->size));
      

      The upd_value->bug should have been pointing to the onpage value when we enter this function. We can resolve modify directly using that buffer. I attempted once but there are failing tests. I didn't bother to spend more time on that as we were close to the release.

        Attachments

          Activity

            People

            Assignee:
            backlog-server-storage-engines Backlog - Storage Engines Team
            Reporter:
            chenhao.qu Chenhao Qu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: