Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-7277

Decide if clearing kpack is actualy needed in __cursor_row_slot_key_return

    • Type: Icon: Improvement Improvement
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      https://github.com/wiredtiger/wiredtiger/blob/42eec1beb18b2e7f0cd7ec7ffeeca58500d14e1e/src/include/cursor_inline.h#L484-L488

      The comment says that it isn't needed, and after seeing it hot in a profile I tried commenting out the memset. In one workload that is dominated by time spent calling cursor->next(), that resulting in a 5% speedup. We should decide whether it is actually unnecessary, and if so, remove it. It may be the case that only a subset of the fields need to be initialized, in which case, it would probably be better to only initialized those fields.

            Assignee:
            keith.bostic@mongodb.com Keith Bostic (Inactive)
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: