Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-7347

Review to remove the compare in __curhs_search_near

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: None
    • Labels:
      None

      Description

                 /*
                   * We find an update when walking forwards. If initially we landed on the same key as
                   * the specified key, we need to compare the keys to see where we are now. Otherwise, we
                   * must have found a key that is larger than the specified key.
                   */
                  if (exact == 0) {
                      WT_ERR(__wt_compare(session, NULL, &file_cursor->key, srch_key, &cmp));
                      *exactp = cmp;
                  } else
                      *exactp = exact;
      

      We added this compare in __curhs_search_near when the history store cursor is initially landed on the exact key. However, we should be able to get rid of it if we can let the previous function calls to tell us if we have moved the underlying file cursor or not. Review this code to see if we want to do that or not.

        Attachments

          Activity

            People

            Assignee:
            backlog-server-storage-engines Backlog - Storage Engines Team
            Reporter:
            chenhao.qu Chenhao Qu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: