Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-7917

Add evergreen validation to s_all

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: WT10.0.1, 4.4.9, 5.0.3, 5.1.0-rc0
    • Component/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Storage - Ra 2021-08-23

      Description

      We could add the following command to our s_all script to make sure we keep our evergreen file correct:

      diff --git a/dist/s_all b/dist/s_all
      index 50d1909ee..a4b7ef4c7 100755
      --- a/dist/s_all
      +++ b/dist/s_all
      @@ -81,6 +81,7 @@ run "./s_clang-format"
       run "python prototypes.py"
       run "sh ./s_typedef -b"
       run "python test_tag.py"
      +run "evergreen validate ../test/evergreen.yml" 

      As of today, it generates the following message:

      ####################### MESSAGE ############################
      s_all run of: "evergreen validate ../test/evergreen.yml" resulted in:
          WARNING: yaml: unmarshal errors:
            line 2868: mapping key "test_env_vars" already defined at line 2863
          ../test/evergreen.yml is valid with warnings
      #######################

      Looking at the corresponding line, test_env_vars is effectively declared twice:

      - name: cppsuite-stress-tests
        display_name: "Cppsuite Stress Tests"
        batchtime: 480 # 3 times a day
        run_on:
        - ubuntu1804-test
        expansions:
          test_env_vars: LD_LIBRARY_PATH=$(pwd)/../../.libs
          make_command: PATH=/opt/mongodbtoolchain/v3/bin:$PATH make
          posix_configure_flags:
            --enable-silent-rules --enable-python --enable-zlib --enable-snappy
            --enable-strict --enable-static
          test_env_vars:
            PATH=/opt/mongodbtoolchain/v3/bin:$PATH
        tasks:
          - name: compile
          - name: cppsuite-hs-cleanup-stress
          - name: cppsuite-base-test-stress 

      I suggest the following scope:

      • Add the new evergreen command to s_all or anywhere that would work
        • EDIT: Add a check to make sure the command is available
      • Fix any warnings raised by the new command when this ticket is addressed

        Attachments

          Activity

            People

            Assignee:
            siddhartha.mahajan Sid Mahajan
            Reporter:
            etienne.petrel Etienne Petrel
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: