Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-8162

Refactor uses of SMOKE arg in 'define_c_test' helper

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • WT10.0.1, 5.0.4, 4.4.10, 5.1.0-rc0
    • None
    • None
    • 3
    • Storage - Ra 2021-10-04

    Description

      We currently use a CMake helper, define_c_test, for defining our csuite tests. An argument you can give is 'SMOKE', which is shorthand for "execute the test with a script named smoke.sh, located in the tests source subdirectory". Using "SMOKE" can be quite confusing as it assumes multiple things about the test and abstracts important details e.g. test arguments, script location.

      Definition of Done:

      • Remove 'SMOKE' and replace it with a parameter to define a custom script e.g. 'EXEC_SCRIPT'. This introduces additional flexibility to define any custom wrapper script i.e. a script not named 'smoke.sh'. Additionally this extra verbosity makes each test definition clear, defining the exact command and arguments to run when ctest is invoked.

      Attachments

        Activity

          People

            alison.felizzi@mongodb.com Alison Felizzi (Inactive)
            alison.felizzi@mongodb.com Alison Felizzi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: