Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-9561

Unify usage of -t and -T parameters in test format binary and format.sh

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • WT11.1.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • 3
    • Storage Engines - 2022-07-11

      Summary
      Test format binary should accept "-T" instead of "-t" to enable tracing. This will make parameters consistent with "format.sh" 

      Motivation

      At the moment test format binary(test/format/t.c) accepts:

      • "-t trace operations in the WiredTiger log"

      and "test/format/format.sh" accepts:

      • "-T turn on format tracing (defaults to off)"
      • "-t minutes   minutes to run (defaults to no limit)"

      This difference is confusing. We need to unify parameters and change to "-T" in test format binary.

      Here's a comment from Keith B:
      "The format binary in the develop branch uses both -t and -T for tracing, and format.sh uses -T for tracing, and -t for the minutes to run timeout. I didn't look, but it's probably historical: format.sh probably had -t for a timeout from when it was first created, and I hacked in -T later to get tracing.

      In the format-mirror branch, I removed -T as an option for format itself at some point, but left -T alone in format.sh, since -t wasn't available.

      It would be an easy change to switch format to use -T instead of -t, then they'd be the same."

            Assignee:
            monica.ng@mongodb.com Monica Ng
            Reporter:
            alexey.anisimov@mongodb.com Alexey Anisimov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: