Uploaded image for project: 'C# Driver'
  1. C# Driver
  2. CSHARP-4358

Update tests that only test against LINQ2 to test against LINQ3 instead of or in addition to LINQ2

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Unknown Unknown
    • 2.19.0
    • Affects Version/s: None
    • Component/s: LINQ3, Testing
    • Labels:
      None

      As part of CSHARP-4331 when LINQ3 becomes the default LINQ provider a number of tests fail because they were assuming LINQ2 was the default. Typically this is because they are asserting against the translation (e.g. filter or pipeline) as returned by LINQ2 when the LINQ3 translation is slightly different, though also correct.

      Note that all the tests in the Linq2ImplementationTests folder should ONLY run against LINQ2 because these tests are by their very nature LINQ2 specific. Every test in the Linq2ImplementationTest folder has a matching test in the Linq3ImplementationTests folder that tests the same test case against LINQ3.

      But there are a modest number of tests outside the LINQ test folders that were also LINQ2 specific. In CSHARP-4331 we made these tests pass by explicitly specifying LINQ2 as the LINQ provider (which makes the test pass because it is now explicitly running against LINQ2 instead of simply by default). These are the tests that should be analyzed to see if the should be refactored to run against both LINQ providers or perhaps run only against LINQ3 (suitably refactored so they pass again).

            Assignee:
            robert@mongodb.com Robert Stam
            Reporter:
            robert@mongodb.com Robert Stam
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: