Uploaded image for project: 'C++ Driver'
  1. C++ Driver
  2. CXX-1543

Absorb or render unnecessary patches used by vcpkg to build the driver

    • Type: Icon: Improvement Improvement
    • Resolution: Works as Designed
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Build
    • None

      We have been packaged by vcpkg, much like we are for homebrew. This is a very good thing for us as it means that now on both MacOS and Windows the driver can be installed by end users without needing to understand the details of how to build the driver.

      However, their integration contains several patches that they drop on the code before building.

      We should research these patches and understand why they are necessary or desirable for vcpkg, and then either take those patches ourselves, or add the necessary build system support to render them unnecessary, so that vcpkg can use the stock code.

      We should also remember to inform the vcpkg maintainer for mongo-cxx-driver (along with the homebrew one), when we make significant changes to our build or install process, so that they aren't caught off guard.

      You can see the current list of patch files here:

      https://github.com/Microsoft/vcpkg/tree/master/ports/mongo-cxx-driver

            Assignee:
            kyle.kloberdanz@mongodb.com Kyle Kloberdanz
            Reporter:
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: