Fix getMore with comment specs

XMLWordPrintableJSON

    • Needed
    • Hide

      Drivers should sync change-streams, aggregate, and find-comment spec tests from mongodb/specifications@ad1ee9b.

      Show
      Drivers should sync change-streams , aggregate , and find-comment  spec tests from  mongodb/specifications@ad1ee9b .
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CXX-2457 Fixed 3.7.0
      CSHARP-4078 Done 2.15.0
      GODRIVER-2321 Duplicate
      JAVA-4507 Fixed 4.6.0
      NODE-4035 Fixed 4.5.0
      MOTOR-901 Duplicate
      PYTHON-3144 Duplicate
      RUBY-2912 Fixed 2.18.0
      RUST-1196 Duplicate
      SWIFT-1504 Duplicate
      PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0
      CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } #scriptField td.willNotDo { background-color: #FF0000; /* Red color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CXX-2457 Fixed 3.7.0 CSHARP-4078 Done 2.15.0 GODRIVER-2321 Duplicate JAVA-4507 Fixed 4.6.0 NODE-4035 Fixed 4.5.0 MOTOR-901 Duplicate PYTHON-3144 Duplicate RUBY-2912 Fixed 2.18.0 RUST-1196 Duplicate SWIFT-1504 Duplicate PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0 CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0

      Summary

      DRIVERS-2189 added specs for getMore command with a comment. There are two problems with those tests:

      1. minServerVersion should be 4.4 since this is the minimal version that supports comment on getMore (see docs).
      2. Those tests should not be run against a sharded cluster. On sharded cluster we can get empty GetMore commands (see spec).

      Is this issue urgent?

      No. It might be easier to implement this together with DRIVERS-742, but this is not required.

      Is this ticket only for tests?

      Yes.

            Assignee:
            Dmitry Rybakov
            Reporter:
            Dmitry Rybakov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: