Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2412

SDAM should prioritize electionId over setVersion only on >=6.0 servers

    XMLWordPrintable

Details

    • Improvement
    • Status: Implementing
    • Unknown
    • Resolution: Unresolved
    • SDAM
    • None
    • Needed
    • Hide
      • Sync spec changes in 37c32c
      • Confirm tests fail with current updateRSFromPrimary implementation
      • Summary of updateRSFromPrimary changes:
        • If maxWireVersion 17 or greater
        • Prioritize electionId before setVersion
        • Handle nullish values for both setVersion and electionId
        • always set maxElectionId and maxSetVersion together (they are a tuple value)
      • Confirm tests pass with changes

      Join #drivers-2412-sdam-should-prioritize-electionid-over-setversion on slack for any questions

      Show
      Sync spec changes in 37c32c Confirm tests fail with current updateRSFromPrimary implementation Summary of updateRSFromPrimary changes: If maxWireVersion 17 or greater Prioritize electionId before setVersion Handle nullish values for both setVersion and electionId always set maxElectionId and maxSetVersion together (they are a tuple value) Confirm tests pass with changes Join #drivers-2412-sdam-should-prioritize-electionid-over-setversion on slack for any questions

    Description

      In DRIVERS-1954, we discovered that the electionId/setVersion change could not be implemented or else drivers would break when replica set restore is run using a pre 6.0 compatible version of Ops Manager.

      Instead of waiting until until these old versions of Ops Manager are EOL, I propose we only implement the new electionId/setVersion comparison logic on >=6.0 servers. This will avoid the regression assuming that old Ops Manager versions do not support backup/restore >=6.0 servers.

      Using this approach we can fix the original bug in DRIVERS-1954 on >=6.0 servers. Drivers will still be vulnerable to the bug on <6.0 servers but that's okay because we're already in that position now.

      Attachments

        Issue Links

          Activity

            People

              neal.beeken@mongodb.com Neal Beeken
              shane.harvey@mongodb.com Shane Harvey
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated: