Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-2781

Resolve linting failures resulting from "revive" bump

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Unknown Unknown
    • None
    • None
    • None
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

    Description

      The sa-lint task in the static analysis build is currently failing. You can find an example of the failure here: https://evergreen.mongodb.com/task/mongo_go_driver_static_analysis_sa_lint_patch_48a21dbbcc3311297d503f0339f69704bdd07a2b_6418e02861837d0fb04aa8b8_23_03_20_22_37_43. The issue is related to the latest release of golangci-lint (version 1.52.0), which includes a revive bump that enforces the "recommended configuration". Unfortunately, this update has caused several linting failures in the Go Driver.

      This fix will also require updating the evergreen config golangci-lint install command to use "latest" instead of "v1.51.2". PR #1211 was created to pin v1.51.2 to allow for green builds.

      Attachments

        Activity

          People

            Unassigned Unassigned
            preston.vasquez@mongodb.com Preston Vasquez
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: