Fix "revive" v1.3.1 linter failures

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Done
    • Priority: Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      The golangci-lint tool recently upgraded revive from v1.3.0 to v1.3.1 (see PR), which causes a bunch of additional "unused-parameter" errors.

      E.g. error:

      bson/bsoncodec/default_value_decoders.go:191:51: unused-parameter: parameter 'dctx' seems to be unused, consider removing or renaming it as _ (revive)
func (dvd DefaultValueDecoders) booleanDecodeType(dctx DecodeContext, vr bsonrw.ValueReader, t reflect.Type) (reflect.Value, error) {

      Definition of done:

      • Resolve all new revive v1.3.1 lint errors

            Assignee:
            Matt Dale
            Reporter:
            Matt Dale
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: