Uploaded image for project: 'Java Driver'
  1. Java Driver
  2. JAVA-5158

Make NettyStreamFactoryFactory implement AutoCloseable

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 5.0.0
    • Affects Version/s: None
    • Component/s: Internal
    • Labels:
    • Fully Compatible
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      By default NettyStreamFactoryFactory creates an NioEventLoopGroup instance and does not close it when the MongoClient closes. We should change the behavior so that it does. We can follow the pattern from TlsChannelStreamFactoryFactory and make it Closeable, and pass it as an externalResourceCloser to the MongoClient implementation.

      Since Netty can technically be used even for sync client, this same pattern needs to be applied there as well.

            Assignee:
            jeff.yemin@mongodb.com Jeffrey Yemin
            Reporter:
            jeff.yemin@mongodb.com Jeffrey Yemin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: