Uploaded image for project: 'Java Driver'
  1. Java Driver
  2. JAVA-5242

Close StreamFactoryFactory when closing sync MongoClient similarly to how its done via reactive MongoClientImpl.externalResourceCloser

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor - P4 Minor - P4
    • None
    • None
    • Connection Management
    • None
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

    Description

      The driver uses NettyStreamFactoryFactory if NettyTransportSettings is specified regardless of whether the sync or reactive API is used. Currently, only the reactive MongoClient closes NettyStreamFactoryFactory, which means that NettyStreamFactoryFactory.eventLoopGroup leaks if NettyTransportSettings is specified and the sync MongoClient is used. There seem to be reasons for specifying NettyTransportSettings when using the sync API, which means we should also close NettyStreamFactoryFactory via the sync MongoClient.

      Attachments

        Activity

          People

            Unassigned Unassigned
            valentin.kovalenko@mongodb.com Valentin Kavalenka
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: