Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3689

Require hello command for connection handshake to use OP_MSG, disallowing OP_QUERY

XMLWordPrintableJSON

    • 3
    • 0
    • Hide

      DRIVERS-1916:
      This ticket does two things:

      1. It clarifies that if the "hello" command is used (as opposed to "isMaster") it must be sent using OP_MSG
      2. Because the previous version of the spec already required that if a versioned API is specified, "hello" must be used, it is made explicit that this also means OP_MSG must be used.

      Drivers must ensure that their connection handshake uses both OP_MSG and "hello" if a versioned API is specified.
      For an example of what your connection process should look like after this change, take a look at the Python implementation in the handshake spec.

      Show
      DRIVERS-1916: This ticket does two things: It clarifies that if the "hello" command is used (as opposed to "isMaster") it must be sent using OP_MSG Because the previous version of the spec already required that if a versioned API is specified, "hello" must be used, it is made explicit that this also means OP_MSG must be used. Drivers must ensure that their connection handshake uses both OP_MSG and "hello" if a versioned API is specified. For an example of what your connection process should look like after this change, take a look at the Python implementation in the handshake spec.
    • Not Needed
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      This ticket was split from DRIVERS-1916, please see that ticket for a detailed description.

      AC

      • Verify that the driver sends hello command + OP_MSG when 'loadBalanced=True'
      • Verify that the driver sends hello command + OP_MSG when versioned API is specified
      • Verify that the driver sends OP_MSG when hello command is supported
      • Investigate sinon for spying on sent messages

            Assignee:
            alena.khineika@mongodb.com Alena Khineika
            Reporter:
            dbeng-pm-bot PM Bot
            Durran Jordan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: