-
Type: Task
-
Resolution: Fixed
-
Priority: Unknown
-
Affects Version/s: None
-
Component/s: None
-
None
Use Case
As a developer
I want references to ismaster to be removed
So that I don't become offended or distracted while working with the Node driver code
From the Scope doc:
Where the deprecated terminology is required, use a constant or variable to abstract away and limit usage of the deprecated term.
User Impact
Unknown
Dependencies
- None
Unknowns
- Should documents named `ismaster` be renamed to `hello`? See src/cmap/auth/mongo_credentials.ts for an example.
- Should lastIsMaster() in topology.ts be renamed to lastPrimary()?
Acceptance Criteria
- All references to ismaster are renamed (e.g. hello) or replaced with a constant(e.g. const LEGACY_HELLO_COMMAND="isMaster")
- Current code ismaster.ismaster = ismaster.isWritablePrimary. Need to flip this
- Any associated documentation that is automatically generated from code comments is also updated to reflect the non-offensive names
Implementation Requirements
- None
Testing Requirements
- None
Documentation Requirements
- None
Follow Up Requirements
- is related to
-
NODE-3091 Stub out Remove Oppressive Language tickets
- Closed
-
NODE-3791 Verify spec files with offensive language match the latest version
- Closed
- related to
-
NODE-4734 Remove usage of deprecated ismaster in next major release after 5.0 is min supported server version
- Backlog
-
NODE-3809 Remove constants for legacy hello command (ismaster and isMaster) when driver no longer supports 4.4
- Backlog
-
NODE-3818 Remove usage of deprecated slaveOk in next major release
- Closed