Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3809

Remove constants for legacy hello command (ismaster and isMaster) when driver no longer supports 4.4

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Unknown Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      Use Case

      As a developer
      I want the tests and source code to not include the offensive "ismaster" term
      So that I don't become offended or distracted while working with the Node driver code

      User Impact

      Unknown

      Dependencies

      • NODE-3790 replaced 'ismaster' in test files with references to a constant
      • NODE-3792 replaced 'ismaster' in source files with references to a constant
      • The driver must no longer support MongoDB 4.4.
        Scope doc: Since drivers must support earlier versions of MongoDB that require the deprecated terminology and return it in responses (4.4 and earlier), isolate these deprecated terms within each driver codebase along with appropriate comments for context.)

      Unknowns

      None

      Acceptance Criteria

      • All references to 'ismaster' are completely removed from the codebase, including tests, source and documentation. Documentation of historical changes (e.g., HISTORY.md) do not need to be updated. Constants of note:
        ./src/constants.ts:export const LEGACY_HELLO_COMMAND = 'ismaster';
        ./src/constants.ts:export const LEGACY_HELLO_COMMAND_CAMEL_CASE = 'isMaster';
        ./src/error.ts:export const LEGACY_NOT_WRITABLE_PRIMARY_ERROR_MESSAGE = 'not master';
        ./src/error.ts:export const LEGACY_NOT_PRIMARY_OR_SECONDARY_ERROR_MESSAGE = 'not master or secondary';

      Implementation Requirements

      Unknown

      Testing Requirements

      Unknown

      Documentation Requirements

      Unknown

      Follow Up Requirements

      Unknown

            Assignee:
            Unassigned Unassigned
            Reporter:
            lauren.schaefer@mongodb.com Lauren Schaefer
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: