-
Type: Task
-
Resolution: Fixed
-
Priority: Unknown
-
Affects Version/s: None
-
Component/s: Logging
-
2
-
0
-
Not Needed
-
Not Needed
-
Currently, our logger's stringifyWithMaxLen function counts each unicode-byte as a unit of length. This can cause multibyte unicode code-points, such as characters in other languages or certain emojis, do get truncated in non-sensical ways. We should round down to the nearest code-point when we encounter this.
Likely will follow implementation in Anna's comment
Use Case
As a... non-english speaking user
I want... logging to support my alphabet
So that... I receive well-formed strings from logger output
User Impact
- Clients with non-english speaking users
- Clients with users who use emojis (would only really be for custom logs)
Dependencies
- None, logging is unreleased
Acceptance Criteria
Implementation Requirements
- When a string contains multi-byte codepoint(s) and is truncated mid code-point round down to the nearest whole codepoint to avoid non "well-formed" strings being outputted to users
Testing Requirements
- Unskip command logging prose test #3 (contains necessary unit testing)