Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-1197

Check for unistd.h when compiling bundled zLib

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 1.4.4
    • Affects Version/s: 1.4.0
    • Component/s: None
    • None

      Consider implementing some checks from zLib's CMakeLists.txt to ensure necessary headers are included, such as unistd.h. This will avoid build warnings for implicit function declarations, which were originally reported in CDRIVER-2666.


      Original description: Per jesse's comment in CDRIVER-2666, PHPC should not use its developer CFLAGS when compiling libmongoc's bundled zlib. This is something libmongoc addressed on their own in CDRIVER-2511. We may have inadvertently started doing this after the Autotools migration (PHPC-1075).

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: