Uploaded image for project: 'Python Driver'
  1. Python Driver
  2. PYTHON-3141

Add slotscheck to pre-commit checks

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Unknown
    • Resolution: Fixed
    • None
    • 4.1
    • None
    • None

    Description

      PYTHON-3124 found in issue with slots via the slotscheck tool:

      I see there have been several _slots_  issues in pymongo in the past. I discovered this slot issue with slotscheck, a tool I maintain. If you like, I can add it to CI as I've done for instagram/LibCST, sqlalchemy/sqlalchemy, and aio-libs/aiohttp.

      We should consider adding slotscheck to our linting checks.

      Attachments

        Issue Links

          related to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. PYTHON-3139 Python Code Formatting

          • Unknown - Priority not determined yet.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PYTHON-3124 _WriteResult subclasses redefine "__acknowledged" slot

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              steve.silvester@mongodb.com Steve Silvester
              shane.harvey@mongodb.com Shane Harvey
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: