Reevaluate handling of asyncio.CancelledError

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Done
    • Priority: Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Python Drivers
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      In PYTHON-4945 we added code to catch and raise CancelledError like this:

              except asyncio.CancelledError:
                  raise
              except Exception:
                  ...
      

      However I now realize this is redundant. CancelledError inherits from BaseException, not Exception, so we can remove these.

      Instead we should only need to audit code that catches BaseException (or bare except). One area we missed is in _client_bulk_shared.py:

          if isinstance(full_result["error"], BaseException):
              raise ClientBulkWriteException(full_result, verbose_results) from full_result["error"]
      

            Assignee:
            Noah Stapp
            Reporter:
            Shane Harvey
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: