Background: During setFCV it is common to add/remove catalog fields by scanning the catalog by DB and running collMod on each collection (example 1, example 2, example 3).

Problem: It's possible for rename across DBs to interleave like this:

• Scan catalog of db1, run collMod over necessary collections
• Rename db2.coll to db1.coll
• Scan catalog of db2, run collMod over necessary collections

In this case the renamed collection will dodge the scans and its metadata will not be changed by setFCV. This issue is very similar to SERVER-87931.

Proposed solution:

• Add a new API catalog::forEachCollectionInAllDbs that is like catalog::forEachCollectionFromDb but takes a single snapshot of the entire catalog (instead of taking a new one for each DB).
• The catalog::modifyAllCollectionsMatching implementation should be changed to use catalog::forEachCollectionInAllDbs.
• We should review all existing uses of the "for (db in dbs) { catalog::forEachCollectionFromDb(db, ...) }{}" pattern since they are likely vulnerable to this race.

A reproducer is attached (for recordIdsReplicated).