Add kickback helper and refactor existing kickbacks

XMLWordPrintableJSON

    • Type: Sub-task
    • Resolution: Fixed
    • Priority: Minor - P4
    • 9.0.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Integration
    • Fully Compatible
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      A helper function will be added to reduce repetition in the kickback logic.

       

      // search_helpers.cpp
void throwIfrKickbackIfNecessary(StringData stageName, 
                                 std::function<bool(std::string)> predicate, 
                                 const IncrementalRolloutFeatureFlag& flag, 
                                 Counter64& metric, 
                                 std::string errorMsg) {
    if (predicate(stageName)) {
       metric.increment();
       uassertStatusOK(
            Status(IFRFlagRetryInfo(flag.getName()), errorMsg));
    }
}

      The existing $vectorSearch kickbacks for views, $unionWith, and hybrid search should be modified to use this helper. This is a refactor so testing is already accomplished with the existing $vectorSearch kickback tests.

            Assignee:
            Daniel Segel
            Reporter:
            Josh Siegel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: