[SERVER-14190] mongorestore parseMetadataFile passes non-null terminated string to 'fromjson' - MongoDB Jira

XML

Word

Printable

JSON

Backwards Compatibility:
Fully Compatible
Operating System:
ALL
Backport Completed:

2.6.8
Steps To Reproduce:
Hide

Run

ASAN_SYMBOLIZER_PATH=<path-to-llvm-symbolizer> buildscripts/smoke.py jstests/multiVersion/dumprestore_24.js

against a mongod built with --sanitize=address.
Show
Run ASAN_SYMBOLIZER_PATH=<path-to-llvm-symbolizer> buildscripts/smoke.py jstests/multiVersion/dumprestore_24.js against a mongod built with --sanitize=address.
Sprint:
Server 2.7.3

https://github.com/mongodb/mongo/blob/master/src/mongo/tools/restore.cpp#L735 reads data from a file, then passes the beginning of that data to 'mongo::fromjson'. However, it does not ensure that there is a terminating NULL character at the end of the buffer.

Found with address sanitizer.